Add ability to cap number of enrollments in a course #1967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lms/djangoapps/courseware/views.py
Outdated
Contributor
There was a problem hiding this comment.
This has the unintuitive effect that if max_student_enrollments_allowed = 0, anyone can enroll.
add a test case for enrollment caps pep8 fix
Contributor
Author
|
@ormsbee I addressed your comments and added test coverage. Think you might have a little time to do a final pass? |
Contributor
|
👍 |
chrisndodge
pushed a commit
that referenced
this pull request
Feb 4, 2014
Add ability to cap number of enrollments in a course
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
* Fix bug. Control at login. openedx#1961 * Fix review. Control at login. openedx#1941 * Mod bok-choy. openedx#1941 * Cancel dev-python-social-auth used. * Used dev-python-social-auth. openedx#1941
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will expose a new field in the Course Module that an author can set the maximum number of participants in a course.