LMS: Use Open Sans Typeface via Google Web Fonts #1968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@frrrances and @dianakhuang, mind taking a look? Also, this may be held up by #1961, or in some way allowing us to specify protocol-relative URLs in CSS files without Django-Pipeline falling over. |
* uses Google Web Fonts reference rather than local files * removes unused local font files * adds in semi-bold weight support
Contributor
|
FYI: this pull request is now good to go -- we can specify protocol-relative URLs in CSS. |
Contributor
|
Lookin good, gettin presents. 👍 |
talbs
added a commit
that referenced
this pull request
Dec 20, 2013
LMS: Use Open Sans Typeface via Google Web Fonts
Contributor
Author
|
Thanks for the http://www.marriedtothesea.com/031908/lookin-good-gettin-presents.gif! Brought this to "Mergetown". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work syncs up how the LMS loads Open Sans (a typeface we use throughout edX's UI) to how its loaded/referenced elsewhere (Studio, Certificates, code.edx.org) - through Google Web Fonts. Key changes include: