ARCH-379: add user_id scope and claim for JWT cookies #19765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes are made to add LMS user_id: * Adds user_id scope to the JWT to provide the LMS user_id. * JWT cookies always use the user_id claim. ARCH-379
Contributor
Author
|
jenkins run bokchoy |
robrap
changed the title
|
Your PR has finished running tests. There were no failures. |
douglashall
approved these changes
Feb 7, 2019
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, February 08, 2019. |
Contributor
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/STAGE_edxapp_M-D |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, February 08, 2019. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
robrap
added a commit
that referenced
this pull request
Mar 27, 2019
This should have been done when the scope was first added as part of (#19765). ARCH-603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are made to add LMS user_id:
ARCH-379: Add call in User Account app to Segment's identify user