Additionally logout from a settings list of extra logout URIs #19790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/read-from-extra-list-of-logout-uris
branch
3 times, most recently
from
3c50d8e to
6b2f573
Compare
doctoryes
approved these changes
Feb 12, 2019
pwnage101
force-pushed
the
pwnage101/read-from-extra-list-of-logout-uris
branch
2 times, most recently
from
6ab2b00 to
85473f1
Compare
Contributor
Author
|
jenkins run bokchoy |
1 similar comment
Contributor
Author
|
jenkins run bokchoy |
pwnage101
force-pushed
the
pwnage101/read-from-extra-list-of-logout-uris
branch
2 times, most recently
from
de5e80c to
9c677a6
Compare
doctoryes
reviewed
Feb 12, 2019
lms/envs/devstack.py
Outdated
Contributor
There was a problem hiding this comment.
According to my testing, both these URIs need a trailing / - so:
'http://localhost:18130/logout/', # ecommerce
'http://localhost:18150/logout/', # credentials
They currently send back a 301 "Moved Permanently" and re-direct.
pwnage101
force-pushed
the
pwnage101/read-from-extra-list-of-logout-uris
branch
from
3e88058 to
985e9dd
Compare
nasthagiri
force-pushed
the
pwnage101/read-from-extra-list-of-logout-uris
branch
from
985e9dd to
d65b4cb
Compare
Currently, the LMS logout endpoint should iframe in the logout pages of all the IDAs you were logged into. In short, this was made possible with DOP because keeping track of the logout URIs and leaving a trail of evidence in the user cookies was part of what we added in our fork of DOP. In the case of DOT, we don't have time or desire to fork DOT to mirror this behavior, so our stop-gap solution is to log out the user from a list of logout URIs in settings.
pwnage101
force-pushed
the
pwnage101/read-from-extra-list-of-logout-uris
branch
from
d65b4cb to
10afe5e
Compare
Contributor
Author
|
jenkins run bokchoy |
1 similar comment
Contributor
Author
|
jenkins run bokchoy |
Contributor
|
jenkins run bokchoy acceptance.tests.studio.test_studio_container.UnitPublishingTest.test_initially_locked_not_visible_to_students |
nasthagiri
approved these changes
Feb 13, 2019
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Thursday, February 14, 2019. |
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the LMS logout endpoint should iframe in the logout pages of
all the IDAs you were logged into. In short, this was made possible with
DOP because keeping track of the logout URIs and leaving a trail of
evidence in the user cookies was part of what we added in our fork of
DOP. In the case of DOT, we don't have time or desire to fork DOT to
mirror this behavior, so our stop-gap solution is to log out the user
from a list of logout URIs in settings.