-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[WIP] SE-760 Public Courses: Show "Enroll" links on public courses only if self-enrollment is allowed #19822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @DevanR! I've created OSPR-3087 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
openedx/features/course_experience/views/course_home_messages.py
Outdated
Show resolved
Hide resolved
| url = course_home_url(self.course) | ||
| response = self.client.get(url) | ||
| self.assertContains(response, TEST_COURSE_HOME_MESSAGE_UNENROLLED) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be combined with existing tests above in line : https://github.com/edx/edx-platform/blob/master/openedx/features/course_experience/tests/views/test_course_home.py#L315
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking into this now and I'm not sure about the changes to be made to the test you referred me. Do I have to make changes in the ddt input for the function? I tried to keep my tests separate, but that function seems to test many different features.
…ks-on-public-courses-only-if-self-enrollment-allowed
|
Your PR has finished running tests. The following contexts failed:
|
|
@DevanR Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@DevanR Thank you for your attempt to contribute. |
|
For reference: this PR was superseded by https://github.com/edx/edx-platform/pull/19837, which was already merged. |
This PR contains bug fixes to the course home page with regards to courses that are marked as "public".
Specifically:
Dependencies: None
Sandbox URL: TBD - sandbox is being provisioned.
Merge deadline: ASAP
Testing instructions:
pytest openedx/features/course_experience/tests/view/test_course_home.py::TestCourseHomePageAccessReviewers