Skip to content

Conversation

@DevanR
Copy link

@DevanR DevanR commented Feb 28, 2019

This PR changes the logic for displaying enroll messages on the course home page.
With this change, public courses will show "Enroll" links only if self-enrollment is allowed

Discussions: Link to any public dicussions about this PR or the design/architecture. Otherwise omit this.

Screenshots:
View when User is unenrolled for Public Outline course (invite-only), before change.
public_outline_invite_unenrolled_before
View when User is unenrolled for Public Outline course (invite-only), after change.
public_outline_invite_unenrolled_after

View when User is unenrolled for Public course (self-enrollment allowed), before change.
public_default_unenrolled_before
View when User is unenrolled for Public course (self-enrollment allowed), after change.
public_default_unenrolled_after

View when User is anonymous for Public course (self-enrollment allowed), before change.
public_default_anon_before
View when User is anonymous for Public course (self-enrollment allowed), after change.
public_default_anon_after

Sandbox URL:
Studio:https://studio-pr19837.sandbox.opencraft.hosting/
LMS:https://pr19837.sandbox.opencraft.hosting/

Merge deadline:"None"

Testing instructions:
Contains 2 courses:

[edX Demo Course] has seo.enable_anonymous_courseware_access course waffle flag, and the "Advanced Settings > Course Visibility For Unenrolled Learners" set to public_outline and the "Advanced Settings > Invitation Only " set to true.
https://pr19837.sandbox.opencraft.hosting/courses/course-v1:edX+DemoX+Demo_Course/

[Test Course] has seo.enable_anonymous_courseware_access course waffle flag, and the "Advanced Settings > Course Visibility For Unenrolled Learners" set to public and the "Advanced Settings > Invitation Only " set to false.
https://pr19837.sandbox.opencraft.hosting/courses/course-v1:opencraft+test01+2019_T1/

Go to LMS
Sign in
View the edX Demo Course course page
You should not see an Enroll message

Go to LMS
Sign in
View the Test Course course page of the public course you've created
You should see an Enroll message

Open the same link in an anonymous browser
You should not see an Enroll message

Reviewers

  • (OpenCraft internal reviewer's GitHub username goes here)
  • Pooja Kulkarni (pkulkark)

@openedx-webhooks
Copy link

Thanks for the pull request, @DevanR! I've created OSPR-3156 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Feb 28, 2019
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@natabene
Copy link
Contributor

@DevanR Thank your for your contribution. Sorry, I am a bit confused, can you let me know if this PR is different from this one: https://github.com/edx/edx-platform/pull/19837 ?

@DevanR
Copy link
Author

DevanR commented Feb 28, 2019

@natabene Apologies for the confusion. I was having some issues squashing my commits, hence the other PR. I've since made the required edits to this PR. Please ignore the new PR.

@pomegranited
Copy link
Contributor

@DevanR Could you close this PR if it's no longer needed?

@DevanR DevanR closed this Mar 1, 2019
@openedx-webhooks
Copy link

@DevanR Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@DevanR DevanR deleted the opencraft/edx-platform/devan/update-enroll-links-on-public-courses branch March 1, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants