The function tzAbbr() causes in non-English version of browsers #2049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returns a non-English timezone string.
Contributor
|
Thanks for the contribution! However, before we can merge it, we need a signed copy of the individual contributor agreement, as documented in the CONTRIBUTING.md file in the repository. You should also add another commit to this pull request adding yourself to the AUTHORS file in the repository. Once you've done those two things, we can assign a reviewer to this pull request, and hopefully get it merged! |
Contributor
|
Thanks, @louyihua: we've received your contributor agreement. @dmitchell, could you please review this pull request? |
Contributor
|
👍 thanks for correcting. It'd be great if it correctly parsed the timezone abbreviation in all localities. Perhaps something to put on the backlog. |
Contributor
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jul 25, 2017
…nosis_generate_csv openedx#2023 openedx#2024 (openedx#2049) * Add command ga_diagnosis_send_data openedx#2023 * Add report email feature to ga_diagnosis_generate_csv command openedx#2024
shimulch
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 26, 2021
This commit adds removal of stale aggregators. Without this following queryset: https://github.com/edx-solutions/api-integration/blob/c46d1f3f4834fbcba3913462853552f8acb7815b/edx_solutions_api_integration/courses/utils.py#L128-L133 returns incorrect set of users, which leads to generating of incorrect metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timezone string does not cotain capital English letters (For example, the timezone string may be a Chinese string), then the following code line will produce a null-reference exception, and the execution of the javascript codes will be stopped, which may cause some strange behaviors in some pages.