Improvements to the i18n workflow tools. #2081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sarina review plz. |
Contributor
Kind of hard to discern where the differences are unless I review each commit separately, which makes commenting hard. |
Contributor
Author
|
Only review changes in the i18n directory. |
Contributor
|
Looks great, just a few comments. 😸 |
Contributor
|
👍 🚢 |
🐑 🐚 🍧 🔯 🎅 🐝 🍺 🍻
added 8 commits
January 7, 2014 09:43
The tests in test_validate.py now examine the messages to see that they have the right structure. The English and the translation should have the same tags, the translation can't be blank, and it can't have any Astral plane characters.
Now any of the plurals being missing will count as an Empty translation, and for looking at tags, the two English strings and all the translated strings are mooshed together.
nedbat
added a commit
that referenced
this pull request
Jan 7, 2014
Improvements to the i18n workflow tools.
shimulch
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are i18n changes, mostly to the i18n tools. But it includes the changes in #2077, don't worry about those.