Logging to catch duplicate instructor tasks #2090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Sorry, I meant that we should see what the most recent InstructorTask is (so the InstructorTask with the highest id). That would let us see if it's seeing the database in an older state.
Contributor
Author
There was a problem hiding this comment.
I'm not sure how to get that, I presume something like InstructorTask.objects.filter(course_id=course_id, task_type=task_type) but is there a better command for that?
Contributor
There was a problem hiding this comment.
Just grab InstructorTask.objects.latest('id') and catch the DoesNotExist error so it doesn't bomb out from the beginning. I'm mostly curious as to what state of the database we can actually read.
Contributor
Author
|
@cpennington is it possible to get this bit of logging code in the release? |
Contributor
|
👍 |
cpennington
added a commit
that referenced
this pull request
Jan 7, 2014
Logging to catch duplicate instructor tasks
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Sep 7, 2017
* addition of test code of the certificate issuance function openedx#2038 (openedx#2054) * Mod translation of 'Course End Date:' openedx#2084 (openedx#2090) * Add menu to ga_operation for ga_analyzer openedx#2039 (openedx#2088) * Fixed bugs openedx#2039 (openedx#2112) * Fixed csv format openedx#2039 (openedx#2127) * Change to split download if there are many display items openedx#916 (openedx#2121) * Change to split download if there are many display items openedx#916 * Fix UT * Fix Review * Fix review2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ormsbee do you think this logging is sufficient to help us trace and debug https://edx-wiki.atlassian.net/browse/LMS-1582 since we won't be able to focus other attention on that story this sprint, but releasing the grades download feature widely may mean we hit the issue a few times?