Fix STUD-1129: handle out-of-range page numbers #2096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 You will need to make a pull request off of the release branch and work with @cpennington to get the fix into the release. |
andy-armstrong
added a commit
that referenced
this pull request
Jan 7, 2014
Fix STUD-1129: handle out-of-range page numbers
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Aug 24, 2017
shimulch
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the assets REST API to return the last page of assets if querying out-of-range. This means that the UI cannot accidentally show a blank page of results. I've added tests that verify the correct behavior in out-of-range conditions.
@cahrens please review.