Skip to content

Conversation

@doctoryes
Copy link
Contributor

Reverts edx/edx-platform#22692

The PR above is causing an error during stage deploy here:
https://gocd.tools.edx.org/go/tab/build/detail/stage-edx-api/63/log/1/deploy_lambda
which needs to be fixed.

Traceback (most recent call last):
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/jsonfield/fields.py", line 83, in pre_init
    return json.loads(value, **self.load_kwargs)
  File "/usr/lib/python3.5/json/__init__.py", line 332, in loads
    return cls(**kw).decode(s)
  File "/usr/lib/python3.5/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.5/json/decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/core/handlers/base.py", line 131, in get_response
    response = middleware_method(request, response)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/newrelic/hooks/framework_django.py", line 320, in wrapper
    return wrapped(*args, **kwargs)
  File "/edx/app/edxapp/edx-platform/openedx/core/djangoapps/site_configuration/middleware.py", line 27, in process_response
    session_cookie_domain = configuration_helpers.get_value('SESSION_COOKIE_DOMAIN')
  File "/edx/app/edxapp/edx-platform/openedx/core/djangoapps/site_configuration/helpers.py", line 110, in get_value
    if is_site_configuration_enabled():
  File "/edx/app/edxapp/edx-platform/openedx/core/djangoapps/site_configuration/helpers.py", line 38, in is_site_configuration_enabled
    configuration = get_current_site_configuration()
  File "/edx/app/edxapp/edx-platform/openedx/core/djangoapps/site_configuration/helpers.py", line 25, in get_current_site_configuration
    return getattr(site, "configuration", None)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/db/models/fields/related_descriptors.py", line 393, in __get__
    rel_obj = self.get_queryset(instance=instance).get(**filter_args)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/db/models/query.py", line 374, in get
    num = len(clone)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/db/models/query.py", line 232, in __len__
    self._fetch_all()
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/db/models/query.py", line 1121, in _fetch_all
    self._result_cache = list(self._iterable_class(self))
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/db/models/query.py", line 63, in __iter__
    obj = model_cls.from_db(db, init_list, row[model_fields_start:model_fields_end])
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/db/models/base.py", line 583, in from_db
    new = cls(*values)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/django/db/models/base.py", line 502, in __init__
    _setattr(self, field.attname, val)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/jsonfield/subclassing.py", line 43, in __set__
    obj.__dict__[self.field.name] = self.field.pre_init(value, obj)
  File "/edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/jsonfield/fields.py", line 85, in pre_init
    raise ValidationError(_("Enter valid JSON"))
django.core.exceptions.ValidationError: ['Enter valid JSON']

@doctoryes doctoryes requested review from a team January 14, 2020 18:05
@doctoryes doctoryes requested a review from a team as a code owner January 14, 2020 18:05
@doctoryes doctoryes requested a review from a team January 14, 2020 18:05
@cpennington
Copy link
Contributor

jenkins run python

@doctoryes
Copy link
Contributor Author

jenkins run bokchoy

@cpennington
Copy link
Contributor

I'm merging this w/o tests finishing, since it's a revert.

@cpennington cpennington merged commit e2f3be9 into master Jan 14, 2020
@cpennington cpennington deleted the revert-22692-juliasq/rename_site_configuration_siteconfiguration_values_1 branch January 14, 2020 18:20
@edx-status-bot
Copy link

Your PR has finished running tests. The following contexts failed:

  • jenkins/quality

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/STAGE_edxapp_M-D

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants