Skip to content

Conversation

@cpennington
Copy link
Contributor

Please consider the following when opening a pull request:

  • Link to the relevant JIRA ticket(s) and tag any relevant team(s).
  • Squash your changes down into one or more discrete commits.
    In each commit, include description that could help a developer
    several months from now.
  • If running make upgrade, run as close to the time of merging as possible
    to avoid accidentally downgrading someone else's package.
    Put the output of make upgrade in its own separate commit,
    decoupled from other code changes.
  • Aim for comprehensive test coverage, but remember that
    automated testing isn't a substitute for manual verification.
  • Carefully consider naming, code organization, dependencies when adding new code.
    Code that is amenable to refactoring and improvement benefits all platform developers,
    especially given the size and scope of edx-platform.
    Consult existing Architectural Decision Records (ADRs),
    including those concerning the app(s) you are changing and
    those concerning edx-platform as a whole.

@cpennington cpennington requested a review from a team January 21, 2020 21:45
@ormsbee
Copy link
Contributor

ormsbee commented Jan 21, 2020

FYI (no action required, but it's likely of interest to you): @davestgermain, @abutterworth, @davidjoy @bradenmacdonald, @symbolist

@cpennington cpennington requested a review from ormsbee January 22, 2020 15:07
Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I don't know if you want to add anything extra about rejected alternatives at the end.

@bradenmacdonald
Copy link
Contributor

Are relative due dates only applicable to self-paced courses?

I'm wondering if it makes sense to have an ultimate goal of converting all course dates to relative dates, and deprecating absolute dates entirely. After all, if I run an instructor-paced course in 2019 and then re-run it in 2020, I'll likely want all the due dates in 2020 to be similar (relative to the start date) to the 2019 course. But my understanding from the documentation is that currently the instructor has to go through the course and manually change all the dates to be (new absolute dates that are) relative to the new start date.

@cpennington
Copy link
Contributor Author

Yes, the goal is to move all courses to relative dates, for exactly the reason you describe. That's a bit further down the pipe, but will be opened up by this work.

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@cpennington cpennington merged commit 8dc53cc into openedx:master Jan 28, 2020
@cpennington cpennington deleted the rel-dates-adr branch January 28, 2020 18:18
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants