-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add ADR for relative courseware dates #22914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI (no action required, but it's likely of interest to you): @davestgermain, @abutterworth, @davidjoy @bradenmacdonald, @symbolist |
lms/djangoapps/courseware/docs/decisions/0004-personalized-relative-dates.rst
Outdated
Show resolved
Hide resolved
lms/djangoapps/courseware/docs/decisions/0004-personalized-relative-dates.rst
Outdated
Show resolved
Hide resolved
lms/djangoapps/courseware/docs/decisions/0004-personalized-relative-dates.rst
Outdated
Show resolved
Hide resolved
lms/djangoapps/courseware/docs/decisions/0004-personalized-relative-dates.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I don't know if you want to add anything extra about rejected alternatives at the end.
lms/djangoapps/courseware/docs/decisions/0004-personalized-relative-dates.rst
Outdated
Show resolved
Hide resolved
lms/djangoapps/courseware/docs/decisions/0004-personalized-relative-dates.rst
Outdated
Show resolved
Hide resolved
|
Are relative due dates only applicable to self-paced courses? I'm wondering if it makes sense to have an ultimate goal of converting all course dates to relative dates, and deprecating absolute dates entirely. After all, if I run an instructor-paced course in 2019 and then re-run it in 2020, I'll likely want all the due dates in 2020 to be similar (relative to the start date) to the 2019 course. But my understanding from the documentation is that currently the instructor has to go through the course and manually change all the dates to be (new absolute dates that are) relative to the new start date. |
|
Yes, the goal is to move all courses to relative dates, for exactly the reason you describe. That's a bit further down the pipe, but will be opened up by this work. |
8e734ce to
ce5b240
Compare
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Please consider the following when opening a pull request:
In each commit, include description that could help a developer
several months from now.
make upgrade, run as close to the time of merging as possibleto avoid accidentally downgrading someone else's package.
Put the output of
make upgradein its own separate commit,decoupled from other code changes.
automated testing isn't a substitute for manual verification.
Code that is amenable to refactoring and improvement benefits all platform developers,
especially given the size and scope of edx-platform.
Consult existing Architectural Decision Records (ADRs),
including those concerning the app(s) you are changing and
those concerning edx-platform as a whole.