Skip to content

Conversation

@robrap
Copy link
Contributor

@robrap robrap commented Jan 28, 2020

Add newrelic metrics and trace details to determine performance issue
in CourseListView.

BOM-897

Please consider the following when opening a pull request:

  • Link to the relevant JIRA ticket(s) and tag any relevant team(s).
  • Squash your changes down into one or more discrete commits.
    In each commit, include description that could help a developer
    several months from now.
  • If running make upgrade, run as close to the time of merging as possible
    to avoid accidentally downgrading someone else's package.
    Put the output of make upgrade in its own separate commit,
    decoupled from other code changes.
  • Aim for comprehensive test coverage, but remember that
    automated testing isn't a substitute for manual verification.
  • Carefully consider naming, code organization, dependencies when adding new code.
    Code that is amenable to refactoring and improvement benefits all platform developers,
    especially given the size and scope of edx-platform.
    Consult existing Architectural Decision Records (ADRs),
    including those concerning the app(s) you are changing and
    those concerning edx-platform as a whole.

@robrap robrap requested review from a team January 28, 2020 14:50
@robrap robrap changed the title add newrelic metrics and trace details BOM-897: add newrelic metrics and trace details Jan 28, 2020
@robrap robrap force-pushed the robrap/BOM-897-add-trace-info branch 2 times, most recently from 15541b8 to 39f1a6e Compare January 28, 2020 16:46
Add newrelic metrics and trace details to determine performance issue
in CourseListView.

BOM-897
@robrap robrap force-pushed the robrap/BOM-897-add-trace-info branch from 39f1a6e to 26d4cc6 Compare January 28, 2020 17:44
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@robrap robrap merged commit a69fce7 into master Jan 28, 2020
@robrap robrap deleted the robrap/BOM-897-add-trace-info branch January 28, 2020 18:22
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants