-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Self paced relative dates #23008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self paced relative dates #23008
Conversation
d929b4e to
df1729c
Compare
|
jenkins run python |
|
jenkins run quality |
e6835e1 to
5618e1e
Compare
|
jenkins run a11y |
jlajoie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just minor string questions but shouldn't hold this up from merging.
Dillon-Dumesnil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, but otherwise looks good to me
771676a to
95b0109
Compare
b707726 to
ade19d9
Compare
ade19d9 to
b47eb0f
Compare
|
jenkins run js |
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Please consider the following when opening a pull request:
In each commit, include description that could help a developer
several months from now.
make upgrade, run as close to the time of merging as possibleto avoid accidentally downgrading someone else's package.
Put the output of
make upgradein its own separate commit,decoupled from other code changes.
automated testing isn't a substitute for manual verification.
Code that is amenable to refactoring and improvement benefits all platform developers,
especially given the size and scope of edx-platform.
Consult existing Architectural Decision Records (ADRs),
including those concerning the app(s) you are changing and
those concerning edx-platform as a whole.