Skip to content

Conversation

@cpennington
Copy link
Contributor

Please consider the following when opening a pull request:

  • Link to the relevant JIRA ticket(s) and tag any relevant team(s).
  • Squash your changes down into one or more discrete commits.
    In each commit, include description that could help a developer
    several months from now.
  • If running make upgrade, run as close to the time of merging as possible
    to avoid accidentally downgrading someone else's package.
    Put the output of make upgrade in its own separate commit,
    decoupled from other code changes.
  • Aim for comprehensive test coverage, but remember that
    automated testing isn't a substitute for manual verification.
  • Carefully consider naming, code organization, dependencies when adding new code.
    Code that is amenable to refactoring and improvement benefits all platform developers,
    especially given the size and scope of edx-platform.
    Consult existing Architectural Decision Records (ADRs),
    including those concerning the app(s) you are changing and
    those concerning edx-platform as a whole.

@cpennington cpennington force-pushed the self-paced-relative-dates branch from d929b4e to df1729c Compare February 5, 2020 18:56
@cpennington
Copy link
Contributor Author

jenkins run python

@cpennington
Copy link
Contributor Author

jenkins run quality

@cpennington cpennington force-pushed the self-paced-relative-dates branch 2 times, most recently from e6835e1 to 5618e1e Compare February 18, 2020 20:18
@cpennington
Copy link
Contributor Author

jenkins run a11y

@cpennington cpennington marked this pull request as ready for review February 18, 2020 20:29
@cpennington cpennington requested review from a team February 18, 2020 20:29
Copy link
Contributor

@jlajoie jlajoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor string questions but shouldn't hold this up from merging.

Copy link
Contributor

@Dillon-Dumesnil Dillon-Dumesnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, but otherwise looks good to me

@cpennington cpennington force-pushed the self-paced-relative-dates branch 2 times, most recently from 771676a to 95b0109 Compare February 20, 2020 14:57
@cpennington cpennington requested a review from a team as a code owner February 20, 2020 14:57
@cpennington cpennington force-pushed the self-paced-relative-dates branch 4 times, most recently from b707726 to ade19d9 Compare February 21, 2020 15:16
@cpennington cpennington force-pushed the self-paced-relative-dates branch from ade19d9 to b47eb0f Compare February 21, 2020 15:50
@cpennington
Copy link
Contributor Author

jenkins run js

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@cpennington cpennington merged commit dca3dbc into openedx:master Feb 21, 2020
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@cpennington cpennington deleted the self-paced-relative-dates branch February 24, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants