AA-33: Function to uniquely create calendar event id for user and assignment #23141
Conversation
Dillon-Dumesnil
changed the title
Dillon-Dumesnil
force-pushed
the
ddumesnil/create-calendar-event-id-AA-33
branch
from
6cf6834 to
cd407bd
Compare
|
jenkins run python |
mikix
left a comment
mikix
left a comment
There was a problem hiding this comment.
calendar is a very broad name. I get that it's directly tied to a calendar. But you could also see the schedule djangoapp name used for this or being confused with calendar. Is there a more specific name we could use?
ics_calendar is too tech specific (and probably an ATM machine issue).
calendar_sync maybe?
I dunno. Whatever, it's great.
openedx/features/calendar/api.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| """ | |||
| API for calendar syncing Course dates with a User. | |||
There was a problem hiding this comment.
Is it our custom to hide these functions inside an api.py? That's fine, but wouldn't we want to import the names into init or something, so users don't have to import from an api file? Seems redundant from their POV.
Dillon-Dumesnil
force-pushed
the
ddumesnil/create-calendar-event-id-AA-33
branch
4 times, most recently
from
21ca128 to
750eba3
Compare
There was a problem hiding this comment.
This needn't block this PR, but blocks can have multiple "kinds" of dates, yeah? I think we mostly focus on the due type, but it's technically possible to have more?
There was a problem hiding this comment.
Great catch. updated
Dillon-Dumesnil
force-pushed
the
ddumesnil/create-calendar-event-id-AA-33
branch
from
750eba3 to
4892653
Compare
The function will create a unique event id using a user and assignment
Dillon-Dumesnil
force-pushed
the
ddumesnil/create-calendar-event-id-AA-33
branch
from
4892653 to
57dbb2d
Compare
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
No description provided.