Revert "Rename values in SiteConfiguration/History (1/3) (retry)" #23230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
requested review from
a team,
HassanJaveed84,
bmedx,
brianhw,
doctoryes,
estute,
hunytalk and
macdiesel
|
Your PR has finished running tests. There were no failures. |
pwnage101
deleted the
revert-23144-pwnage101/rename_site_configuration_siteconfiguration_values_1.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts edx/edx-platform#23144
We tried merging stage 2, but the migration failed because we missed adding a default
{}value tosite_valuesin the history table. The safest path forward is to roll all the way back to the beginning and start over.DENG-18