Skip to content

Swap courseware-mfe CourseWaffleFlag with ExperimentWaffleFlag #23429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abutterworth merged 5 commits into from
Mar 23, 2020
Merged

Swap courseware-mfe CourseWaffleFlag with ExperimentWaffleFlag #23429

abutterworth merged 5 commits into from
Mar 23, 2020

Conversation

@abutterworth
Copy link
Contributor

@abutterworth abutterworth commented Mar 17, 2020 •
edited
Loading

TNL-7000

Use ExperimentWaffleFlag instead of CourseWaffleFlag for its user bucketing functionality. More info here.

Relates to #23016

@abutterworth abutterworth requested a review from a team March 17, 2020 15:02
ormsbee
ormsbee requested changes Mar 17, 2020
View reviewed changes
@abutterworth abutterworth requested a review from ormsbee March 17, 2020 15:30
ormsbee
ormsbee reviewed Mar 17, 2020
View reviewed changes
ormsbee
ormsbee reviewed Mar 17, 2020
View reviewed changes
stvstnfrd
stvstnfrd reviewed Mar 18, 2020
View reviewed changes
mikix
mikix reviewed Mar 19, 2020
View reviewed changes
@edx-status-bot
Copy link

edx-status-bot commented Mar 19, 2020

Your PR has finished running tests. There were no failures.

@abutterworth abutterworth merged commit 1f59463 into master Mar 23, 2020
@abutterworth abutterworth deleted the abutterworth/courseware-mfe-experiment-toggle branch March 23, 2020 17:46
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 24, 2020

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 24, 2020

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 24, 2020

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 24, 2020

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Mar 24, 2020

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ormsbee ormsbee ormsbee approved these changes

@davidjoy davidjoy Awaiting requested review from davidjoy

@davestgermain davestgermain Awaiting requested review from davestgermain

+2 more reviewers

@mikix mikix mikix left review comments

@stvstnfrd stvstnfrd stvstnfrd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@abutterworth @edx-status-bot @edx-pipeline-bot @ormsbee @mikix @stvstnfrd