Skip to content

Stop using JavaScript to set the body's CSS class #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talbs merged 1 commit into from
Feb 6, 2014
Merged

Stop using JavaScript to set the body's CSS class #2476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lms/templates/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@

<%block name="pagetitle">${_("Log into your {platform_name} Account").format(platform_name=platform_name)}</%block>

<%block name="bodyclass">view-login</%block>

<%block name="js_extra">
<script type="text/javascript">
$(function() {

var view_name = 'view-login';

// adding js class for styling with accessibility in mind
$('body').addClass('js').addClass(view_name);
$('body').addClass('js');

// show forgot password modal UI if URL contains matching DOM ID
if ($.deparam.fragment()['forgot-password-modal'] !== undefined) {
Expand Down
6 changes: 3 additions & 3 deletions lms/templates/register-shib.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@

<%block name="pagetitle">${_("Preferences for {platform_name}").format(platform_name=settings.PLATFORM_NAME)}</%block>

<%block name="bodyclass">view-register</%block>

<%block name="js_extra">
<script type="text/javascript">
$(function() {

var view_name = 'view-register';

// adding js class for styling with accessibility in mind
$('body').addClass('js').addClass(view_name);
$('body').addClass('js');

// new window/tab opening
$('a[rel="external"], a[class="new-vp"]')
Expand Down
6 changes: 3 additions & 3 deletions lms/templates/register.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@

<%block name="pagetitle">${_("Register for {platform_name}").format(platform_name=platform_name)}</%block>

<%block name="bodyclass">view-register</%block>

<%block name="js_extra">
<script type="text/javascript">
$(function() {

var view_name = 'view-register';

// adding js class for styling with accessibility in mind
$('body').addClass('js').addClass(view_name);
$('body').addClass('js');

// new window/tab opening
$('a[rel="external"], a[class="new-vp"]')
Expand Down
4 changes: 1 addition & 3 deletions lms/templates/registration/password_reset_complete.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,8 @@
<script type="text/javascript">
$(function() {

var view_name = 'view-passwordreset';

// adding js class for styling with accessibility in mind
$('body').addClass('js').addClass(view_name);
$('body').addClass('js');

// new window/tab opening
$('a[rel="external"], a[class="new-vp"]')
Expand Down
4 changes: 1 addition & 3 deletions lms/templates/registration/password_reset_confirm.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@
<script type="text/javascript">
$(function() {

var view_name = 'view-passwordreset';

// adding js class for styling with accessibility in mind
$('body').addClass('js').addClass(view_name);
$('body').addClass('js');

// new window/tab opening
$('a[rel="external"], a[class="new-vp"]')
Expand Down