[BB-2967] Remove report path from task output data

[xitij2000]

In a previous PR (https://github.com/edx/edx-platform/pull/19986) to implement a report status UI, a change was made that added the report path to the task output. This was to simplify getting this data during the task progress, so we could update the UI with it. However, this change makes the task output too large which causes it to fail in the last step in many cases.

This PR updates the code to use alternative method for getting report download link using the report downloads list.

JIRA tickets: OSPR-4931

Discussions: https://github.com/edx/edx-platform/pull/19986#issuecomment-682377341

Dependencies: None

Sandbox URL:
LMS: https://pr24867.sandbox.opencraft.hosting/
Studio: https://studio.pr24867.sandbox.opencraft.hosting/

Merge deadline: ASAP

Testing instructions:

1. Visit the instructor dashboard.
2. Generate a problem responses report
3. Check that browser console for requests to the instructor_task_status endpoint
4. Without applying this PR, they should include a report_path parameter
5. After applying this PR that parameter is no longer present.

Reviewers

• @0x29a
• edX reviewer[s] TBD

Settings

EDXAPP_FEATURES:
  ENABLE_COMBINED_LOGIN_REGISTRATION: true

[openedx-webhooks]

Thanks for the pull request, @xitij2000! I've created OSPR-4931 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[DawoudSheraz]

@xitij2000 Hi. Just to catch-up, do we have an estimated timeline for this PR review and merge? Thanks

[xitij2000]

@DawoudSheraz Unfortunately I will only find time to properly work on this next sprint. There are still some issues and it needs an internal review.

[natabene]

@xitij2000 Thank you for your contribution. Please let me know once it is ready for our review.

[DawoudSheraz]

@xitij2000 Changes look good. I have tested on sandbox too. Please let me know the expected merge timeline after your internal review.

[0x29a]

@xitij2000, I noticed new error in console:

It's very minor, you can fix it by changing: https://github.com/edx/edx-platform/blob/64c2226a44246af165a8ef09fa9e136c056d5680/lms/djangoapps/instructor/static/instructor/ProblemBrowser/components/Main/Main.jsx#L46

To this:

<input type="text" name="problem-location" value={selectedBlock || ''} disabled />

[0x29a]

👍 after fixing mentioned error.

• I tested that requests to instructor_task_status don't contain report_path parameter
• I read through the code
• I checked for accessibility issues No new interfaces introduced.
• Includes documentation No need in additional documentation here.
• I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

[xitij2000]

@xitij2000, I noticed new error in console:

It's very minor, you can fix it by changing:

https://github.com/edx/edx-platform/blob/64c2226a44246af165a8ef09fa9e136c056d5680/lms/djangoapps/instructor/static/instructor/ProblemBrowser/components/Main/Main.jsx#L46

To this:

<input type="text" name="problem-location" value={selectedBlock || ''} disabled />

I've fixed it a different way. This is happening because the original value for selected block in null in the reducer. I've now set it to an empty string.

[xitij2000]

@natabene This is ready for edX review.

CC: @DawoudSheraz

[natabene]

@DawoudSheraz Can you review this and merge if you find it good?

[DawoudSheraz]

@DawoudSheraz Can you review this and merge if you find it good?

Sure.

[DawoudSheraz]

@xitij2000 Will the related tests be added in a follow-up PR? Other than that, the changes look good to me.

[DawoudSheraz]

@xitij2000 Also, can you rebase and squash. your commits? The tests seem to be stuck in getting the status back. I want to get this merged today if possible.

[DawoudSheraz]

jenkins run py38 quality

[edx-status-bot]

Your PR has finished running tests. There were no failures.

[openedx-webhooks]

@xitij2000 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the production environment.