-
Notifications
You must be signed in to change notification settings - Fork 4.2k
SE-3247 Allow custom node env variables for plugins #25022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SE-3247 Allow custom node env variables for plugins #25022
Conversation
|
Thanks for the pull request, @pkulkark! I've created OSPR-4988 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
4a7b6e8 to
560d4cd
Compare
|
@pkulkark Thank you for your contribution. Please let me know once this is ready for our review. |
mavidser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkulkark Small nit - else LGTM 👍
- I tested this: Accessed
process.env.ADDITIONAL_NODE_ENV_VARSfrom some compiled js files and was able to access defined variables. - I read through the code
- I checked for accessibility issues
560d4cd to
0f7d63b
Compare
This adds a way for tinymce plugins to use custom environment variables.
0f7d63b to
e28ed7e
Compare
…-custom-node-env-variables
f54e0b1 to
c4be8c7
Compare
|
@pkulkark Is this good for our review? |
|
Your PR has finished running tests. The following contexts failed:
|
|
@pkulkark Could you please rebase this PR and ensure this is ready for review? Or if the feature is not needed anymore close the PR? |
|
@gabor-boros @pkulkark I believe this pull request should have been closed because it was addressed in other pull requests with a different approach (https://github.com/edx/configuration/pull/6179, https://github.com/edx/edx-platform/pull/25695, https://github.com/edx/edx-platform/pull/25324). |
|
@pkulkark Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
One of our clients require to be able to send customizable values to their custom tinymce plugin that they want to use in studio. This PR adds the ability to share additional node environment variables that are set in django settings file with any js plugins. They can then be accessed via
process.env.<variable-name>.JIRA tickets: OSPR-4988
Sandbox URL: TBD - sandbox is being provisioned
Testing Instructions:
ADDITIONAL_NODE_ENV_VARSvariable in cms/envs/common.py file.process.env.ADDITIONAL_NODE_ENV_VARS.Reviewers: