Rollback Django Debug Toolbar from 1.0.1 to 0.9.4 #2640
Conversation
There was a problem hiding this comment.
Is this comment no longer helpful? Are these not the versions we are on?
There was a problem hiding this comment.
I've added it back in. Thanks for the catch.
|
👍 |
|
Can you link to the PR you are reverting? |
|
You need to revert https://github.com/edx/edx-platform/pull/2627 as well. 🍞 |
|
This pull request reverts #2391, #2627, and #2634. @davestgermain, thanks for reminding me about #2627 -- I've added that revert to this pull request now. |
requirements/edx/base.txt
Outdated
There was a problem hiding this comment.
- devstack should run the same as dev
There was a problem hiding this comment.
Added that, as well. Thanks!
|
👍 |
Due to issues with require.js and the latest version of the toolbar. Also included a note in the requirements file explaining the situation, and what needs to happen before this can be upgrade properly.
Rollback Django Debug Toolbar from 1.0.1 to 0.9.4
|
a belated 👍 - the changes / PR I made was strictly in response to an early (and incomplete) change to toolbar 1.*, a "... if you're going to do that, then you should do all of the updates here..."; Other than that, I have no dog in this fight - and as you mention DDT is still figuring out... this makes sense. |
We recently tried to update our version of Django Debug Toolbar from 0.9.4 to 1.0.1 (#2391). Doing so caused a lot of problems -- at first, being unable to run the codebase at all due to backwards-incompatible changes in the toolbar's Python code, and then when that was resolved, broken Javascript due to the interaction between DDT's Javascript and ours. Since DDT is still figuring out how to move forward with their Javascript changes, we're going to rollback to 0.9.4 for now. I'm also adding a note to the codebase explaining the situation, so we don't run into this again, and once again get bitten by insufficient testing.
@cpennington @cahrens @yarko Can you verify that this is what we want?
Sorry for the instability in the project, everyone. 😓