refactor: make xmodule & openedx independent of code in cms#27874
Merged
kdmccormick merged 3 commits intomasterfrom Jun 9, 2021
Merged
refactor: make xmodule & openedx independent of code in cms#27874kdmccormick merged 3 commits intomasterfrom
kdmccormick merged 3 commits intomasterfrom
Conversation
Member
Author
|
jenkins runs python |
Member
Author
|
jenkins run python |
kdmccormick
force-pushed
the
kdmccormick/xmodule-no-cms
branch
from
44c54cd to
53b5cf8
Compare
This is a minor refactoring in order to remove a code dependency of ./opendedx on ./cms
This is a minor refactoring in order to remove a code dependency of ./xmodule on ./cms
This is a minor refactoring in order to remove a code dependency of ./xmodule on ./cms
kdmccormick
force-pushed
the
kdmccormick/xmodule-no-cms
branch
from
53b5cf8 to
7a26ec6
Compare
kdmccormick
changed the title
kdmccormick
changed the title
kdmccormick
changed the title
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In BOM-2576 (see draft PR), we will begin constraining imports in edx-platform. Two such constraints will be:
./common/lib/xmodule/xmodulemay not import from./cms../openedxmay not import from./cms.This PR makes three small refactorings (separated by commit) that make the above constraints true.
Why?
The
xmoduleandopenedxpackages both contain code that is common between LMS and CMS. Thecmspackage is, of course, contains CMS-specific code.So, one prerequisite to extracting CMS into an independent service will be making sure that
lms,common,openedx, and the projects in common/lib (xmodule,capa, etc.) are not coupled to any CMS-specific features.Testing instructions
None
Deadline
None