ensure every python source dir has an __init__.py file#27875
ensure every python source dir has an __init__.py file#27875kdmccormick merged 3 commits intomasterfrom
Conversation
8eb56cf to
0f53ccd
Compare
e8c7399 to
92140b3
Compare
92140b3 to
b69d34f
Compare
|
jenkins run python |
b69d34f to
5d2a69b
Compare
|
📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build. We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master. This branch has been detected to not have commit 2e33565 as an ancestor. Here's how to see for yourself: If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal). |
5d2a69b to
cf315c4
Compare
747558a to
4f09d26
Compare
4f09d26 to
d5a3500
Compare
0f568fe to
7042912
Compare
|
Your PR has finished running tests. There were no failures. |
|
Tested the newly added directories to be successfully producing |
|
Thanks Usama! |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
Several Python source directories in edx-platform are quietly being skipped by pylint because they don’t have an
__init__.pyfile. Furthermore,import-linterrequires that every Python source dir have an__init__.pyfile.This PR:
__init__.pyfiles.__init__.py.__init__.pyfile going forward.Supporting information
See BOM-2593 for details.
Testing instructions
Deadline
None. (On hold until Arbi-BOM is able to pick this work back up)
Sooner is better, though, since new edx-platform directories are regularly created, which will add to the pylint debt.
Other information
Christie took care of some of this already for Aperture-owned directories in https://github.com/edx/edx-platform/pull/27972
Prerequisite to https://github.com/edx/edx-platform/pull/27011 (import linting)