Skip to content

Conversation

@jvdm
Copy link
Contributor

@jvdm jvdm commented Jul 3, 2021

Description

This PR ports and rebases all the changes to support LTI 1.3. on Blockstore-based Content Libraries. It should contain the same changes already provided by the related PRs, as well as any additional changes related to making it work in the Lilac release.

At this moment, the changes are:

  1. https://github.com/edx/edx-platform/pull/27411 - Core LTI 1.3. support code.
  2. https://github.com/edx/edx-platform/pull/27715 - Management command to import Courseware blocks (modulestore) into Blockstore through content libraries.
  3. [SE-4399] feat: add LTI URL copy feature openedx-unsupported/frontend-app-library-authoring#22 - MFE changes to allow customers to copy the LTI launch URLs.
  4. https://github.com/edx/edx-platform/pull/27712 - Backed changes to support the above.

Testing instructions

Same as https://github.com/edx/edx-platform/pull/27411 and their companions, except:

  1. You should checkout this PR's branch at edx/edx-platform repo in your devstack.

Deadline

None.

Other information

None.

Reviewers


Settings

EDXAPP_FEATURES:
  ENABLE_COMBINED_LOGIN_REGISTRATION: true

COMMON_ECOMMERCE_BASE_URL: '{{ EDXAPP_ECOMMERCE_PUBLIC_URL_ROOT }}'
EDXAPP_CELERY_BROKER_TRANSPORT: amqp

EDXAPP_VIDEO_IMAGE_SETTINGS:
  VIDEO_IMAGE_MAX_BYTES: 2097152
  VIDEO_IMAGE_MIN_BYTES: 2048

  STORAGE_KWARGS:
    bucket: '{{ EDXAPP_AWS_STORAGE_BUCKET_NAME }}'
    location: video-images/

EDXAPP_VIDEO_TRANSCRIPTS_SETTINGS:
  VIDEO_TRANSCRIPTS_MAX_BYTES: 3145728
  STORAGE_KWARGS:
    bucket: '{{ EDXAPP_AWS_STORAGE_BUCKET_NAME }}'
    location: video-transcripts/

EDXAPP_FEATURES_EXTRA:
  ENABLE_LIBRARY_AUTHORING_MICROFRONTEND: true
  ENABLE_CORS_HEADERS: true

TRUSTED_DOMAINS:
  - 'blockstore.{{ EDXAPP_LMS_BASE }}'
  - 'library-authoring.{{ EDXAPP_LMS_BASE }}'

EDXAPP_ENABLE_CORS_HEADERS: yes
EDXAPP_ENABLE_CROSS_DOMAIN_CSRF_COOKIE: yes
EDXAPP_CORS_ORIGIN_WHITELIST: '{{ TRUSTED_DOMAINS }}'
EDXAPP_LOGIN_REDIRECT_WHITELIST: '{{ TRUSTED_DOMAINS }}'
EDXAPP_CSRF_TRUSTED_ORIGINS: '{{ TRUSTED_DOMAINS }}'
EDXAPP_LIBRARY_AUTHORING_MICROFRONTEND_URL: 'https://library-authoring.{{ EDXAPP_LMS_BASE }}'
MFE_DEPLOY_STANDALONE_NGINX: yes

MFES:
  - name: library-authoring
    repo: frontend-app-library-authoring
    env_extra:
      STUDIO_BASE_URL: https://{{ EDXAPP_CMS_BASE }}

## BLOCKSTORE
## ============

# Do not run blockstore, use Gabor's instance.
SANDBOX_ENABLE_BLOCKSTORE: false
EDXAPP_BLOCKSTORE_API_URL: https://blockstore.gabor-boros.opencraft.hosting/api/v1/

EDXAPP_LMS_ENV_EXTRA:
    BLOCKSTORE_API_AUTH_TOKEN: 19a2e55d-c4fa-4cd2-8f37-d15d01cedb10

EDXAPP_CMS_ENV_EXTRA:
    BLOCKSTORE_API_AUTH_TOKEN: 19a2e55d-c4fa-4cd2-8f37-d15d01cedb10

Offers blockstore-based content through content libraries acting as an
LTI 1.3 tool:

- Content Library support LTI 1.3 launches offering blockstore-based
  content through resource links.

- Content Library support LTI 1.3. AGS, allowing gradebook updates from
  graded assignments.

- Command line management tool to import course content from courseware
  (modulestore) into Content Libraries (blockstore).

- UI updates to generate LTI launch URLs from its libraries.

Merge remote-tracking branch 'origin/gabor/add-block-lti-url' into jvdm/sandbox

Merge remote-tracking branch 'origin/jvdm/libraries-v2-import-from-courseware' into jvdm/sandbox

Merge remote-tracking branch 'remotes/origin/gabor/paginate-library-list' into jvdm/sandbox

Update requirements
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jul 3, 2021
@openedx-webhooks
Copy link

Thanks for the pull request, @jvdm! I've created BLENDED-908 to keep track of it in Jira. More details are on the BD-14 project page.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@arbrandes
Copy link
Contributor

@jvdm, thanks for this! We'll likely want to split them backup into separate PRs for actual merging once their corresponding master PRs land, but this makes it very practical to test, which I'll do this week.

@jvdm jvdm closed this Oct 5, 2021
@openedx-webhooks
Copy link

@jvdm Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-webhooks openedx-webhooks added rejected and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants