Use a "through" model for the ManyToManyField fields - phase 3 #28109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctoryes
force-pushed
the
juliasq/TNL-8314_integrity_error_learning_sequences_phase_3
branch
3 times, most recently
from
f0b7cde to
700cee1
Compare
doctoryes
changed the base branch from
master
to
juliasq/TNL-8314_integrity_error_learning_sequences_phase_2
doctoryes
force-pushed
the
juliasq/TNL-8314_integrity_error_learning_sequences_phase_3
branch
from
700cee1 to
9313c1f
Compare
doctoryes
force-pushed
the
juliasq/TNL-8314_integrity_error_learning_sequences_phase_2
branch
from
feecd67 to
58c36d4
Compare
doctoryes
force-pushed
the
juliasq/TNL-8314_integrity_error_learning_sequences_phase_3
branch
from
9313c1f to
2d3a062
Compare
Base automatically changed from
juliasq/TNL-8314_integrity_error_learning_sequences_phase_2
to
master
July 12, 2021 18:03
…ction and CourseSectionSequence to ensure that cascading deletes will occur to delete the relation upon deletion of a foreign-keyed object. This commit is phase 3 of 4 in order to ensure a smooth deploy. The phases: 1) Add separate through models for user partition groups, add fields to point to the separate models, and start writing to those fields as well. (COMPLETE) 2) After all models have been re-generated, switch code over to use separate through model fields backed by the separate through models *and* stop writing to the original ManyToManyField field. (COMPLETE) 3) After phase 2 is deployed smoothly, remove the original ManyToManyField fields. (This PR!) 4) After phase 3 is deployed smoothly, rename the new fields to have the same name as the old fields, so new_user_partition_groups -> user_partition_groups. This PR is designed to be able to easily be rolled-back if anything goes wrong.
doctoryes
force-pushed
the
juliasq/TNL-8314_integrity_error_learning_sequences_phase_3
branch
from
2d3a062 to
e655fc9
Compare
|
Your PR has finished running tests. There were no failures. |
ormsbee
approved these changes
Jul 13, 2021
doctoryes
deleted the
juliasq/TNL-8314_integrity_error_learning_sequences_phase_3
branch
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: Use a "through" model for the ManyToManyField fields in CourseSection and CourseSectionSequence to ensure that cascading deletes will occur to delete the relation upon deletion of a foreign-keyed object.
This commit is phase 3 of 4 in order to ensure a smooth deploy. The phases:
separate models, and start writing to those fields as well. (COMPLETE)
model fields backed by the separate through models and stop writing to the original
ManyToManyField field. (COMPLETE)
as the old fields, so
new_user_partition_groups->user_partition_groups.This PR is designed to be able to easily be rolled-back if anything goes wrong.
Supporting information
https://openedx.atlassian.net/browse/TNL-8314
Phase 1 PR: https://github.com/edx/edx-platform/pull/27941
Phase 2 PR: https://github.com/edx/edx-platform/pull/28032
Testing instructions
Deadline
None