Skip to content

Revert "[BD-13] Let ModuleSystem use UserService" #28857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ormsbee merged 1 commit into from
Sep 27, 2021
Merged

Revert "[BD-13] Let ModuleSystem use UserService" #28857

ormsbee merged 1 commit into from
Sep 27, 2021

Conversation

@ormsbee
Copy link
Contributor

@ormsbee ormsbee commented Sep 27, 2021 •
edited
Loading

Reverts edx/edx-platform#28440

FYI @pomegranited and @symbolist: Reverting over issues around anonymous_student_id values. Will update with more information shortly.

connorhaugh
connorhaugh approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it matches the og PR. lgtm. i will keep an ear to the ground incase revert causes problems.

@edx-status-bot
Copy link

edx-status-bot commented Sep 27, 2021

Your PR has finished running tests. There were no failures.

@ormsbee ormsbee merged commit deaf80f into master Sep 27, 2021
@ormsbee ormsbee deleted the revert-28440-jill/BD-13-user-service branch September 27, 2021 19:42
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Sep 27, 2021

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@pomegranited
Copy link
Contributor

pomegranited commented Sep 28, 2021

@ormsbee bummer :(

Could it have to do with this change? We dropped the is_pure_xblock check because that should be true for everything now, but maybe it's not? CC @symbolist

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Sep 28, 2021

EdX Release Notice: This PR has been deployed to the production environment.

@pomegranited
Copy link
Contributor

pomegranited commented Oct 4, 2021

Hi @ormsbee , I'm away until 18 Oct, but would like to address this when I return.
Do you have any more information about what issue this caused in production?

@ormsbee
Copy link
Contributor Author

ormsbee commented Oct 13, 2021

@pomegranited: I'll post up an example before you get back. Thank you.

@pomegranited
Copy link
Contributor

pomegranited commented Oct 19, 2021

Hi @ormsbee 👋 Do you have any more information about this issue? Thank you!

pomegranited referenced this pull request in open-craft/openedx-platform Oct 26, 2021
@pomegranited
temp: adds debugging to diagnose issue with anonymous_user_id
74b70e1 
cf https://github.com/edx/edx-platform/pull/28857
@pomegranited pomegranited mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@connorhaugh connorhaugh connorhaugh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ormsbee @edx-status-bot @edx-pipeline-bot @pomegranited @connorhaugh