-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[SE-4631] add CCX ID to generated filename prefixes (#27028) #29100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SE-4631] add CCX ID to generated filename prefixes (#27028) #29100
Conversation
|
Thanks for the pull request, @gabor-boros! I've created OSPR-6165 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@gabor-boros Thank you for this PR. Please let me know once this is ready for our review. |
pkulkark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabor-boros LGTM 👍
- I tested this: Verified that the filename contains the required ccx prefix as described in the testing instructions
- I read through the code
-
I checked for accessibilityN/A -
Includes documentationN/A
|
@natabene this is ready for edX review. Thank you! |
|
Thank you for your approval on https://github.com/edx/edx-platform/pull/29101, @BbrSofiane! Since you already approved that PR (which is literally the same as this one), may I get a review from you here too? 😇 |
|
@gabor-boros yep no problem. @edx-community-bot merge. |
|
@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is the backport of https://github.com/edx/edx-platform/pull/27028.
This pull requests backport a feature to include CCX course IDs in the generated course filenames used for downloading reports, etc.
The suffix appended to the generated filename prefix is following the
<separator>_ccx_<ccx id>pattern, to ensure unique filename generation per ccx - previously all CCX courses were downloaded with the same name.Dependencies: None
Screenshots:

Sandbox URL: TBD
Merge deadline: None
Testing instructions: