Skip to content

Conversation

@ormsbee
Copy link
Contributor

@ormsbee ormsbee commented Oct 27, 2021

Reverts edx/edx-platform#28749

The commit being reverted caused the following test failure on the master branch:

Error Message
AssertionError: assert True == False
  +True
  -False
Stacktrace
self = <openedx.features.lti_course_tab.tests.DiscussionLtiCourseTabTestCase testMethod=test_pii_params_on_discussion_lti_tab_1_True>
discussion_config_enabled = True

    @ddt.data(True, False)
    @patch('common.djangoapps.student.models.CourseEnrollment.is_enrolled', Mock(return_value=True))
    def test_pii_params_on_discussion_lti_tab(self, discussion_config_enabled):
        self.discussion_config.enabled = discussion_config_enabled
        self.discussion_config.save()
        tab = self.check_discussion_tab()
>       self.check_can_display_results(
            tab,
            for_staff_only=True,
            for_enrolled_users_only=True,
            expected_value=discussion_config_enabled,
        )

openedx/features/lti_course_tab/tests.py:48: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <openedx.features.lti_course_tab.tests.DiscussionLtiCourseTabTestCase testMethod=test_pii_params_on_discussion_lti_tab_1_True>
tab = <openedx.features.lti_course_tab.tab.DiscussionLtiCourseTab object at 0x7f65d7fca430>
expected_value = True, for_authenticated_users_only = False
for_staff_only = True, for_enrolled_users_only = True

    def check_can_display_results(
            self,
            tab,
            expected_value=True,
            for_authenticated_users_only=False,
            for_staff_only=False,
            for_enrolled_users_only=False
    ):
        """Checks can display results for various users"""
        if for_staff_only:
            user = self.create_mock_user(is_staff=True, is_enrolled=True)
>           assert expected_value == self.is_tab_enabled(tab, self.course, user)
E           AssertionError: assert True == False
E             +True
E             -False

lms/djangoapps/courseware/tests/test_tabs.py:164: AssertionError

@dianakhuang points out that this may be because of an adverse interaction with:

@ormsbee
Copy link
Contributor Author

ormsbee commented Oct 27, 2021

FYI @xitij2000, @awaisdar001, @asadazam93, @Agrendalath

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@ormsbee ormsbee merged commit 5d01323 into master Oct 27, 2021
@ormsbee ormsbee deleted the revert-28749-kshiitj/discussions-structure-in-course branch October 27, 2021 14:40
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants