Skip to content

[BB-4649] cherry-pick: Duplicate Arabic month#29208

Closed
shimulch wants to merge 1 commit intoopenedx:open-release/lilac.masterfrom
open-craft:shimulch/fix-duplicate-arabic-month
Closed

[BB-4649] cherry-pick: Duplicate Arabic month#29208
shimulch wants to merge 1 commit intoopenedx:open-release/lilac.masterfrom
open-craft:shimulch/fix-duplicate-arabic-month

Conversation

@shimulch
Copy link

@shimulch shimulch commented Nov 3, 2021

Description

This is a cherry-pick of already merged https://github.com/edx/edx-platform/pull/28486
This exists on Master and Maple but not in Lilac.

Supporting information

https://github.com/edx/edx-platform/pull/28486

Testing instructions

https://github.com/edx/edx-platform/pull/28486

…te-arabic-month

[BB-4649] fix: Duplicate Arabic month

(cherry picked from commit 31854bd)
@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Nov 3, 2021
@openedx-webhooks
Copy link

Thanks for the pull request, @shimulch! I've created OSPR-6203 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link
Contributor

natabene commented Nov 4, 2021

@shimulch Thank you for your contribution. Is this ready for a review?

@shimulch
Copy link
Author

Changes are already in master and maple, don't need to have lilac support.

@openedx-webhooks
Copy link

@shimulch Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@shimulch shimulch deleted the shimulch/fix-duplicate-arabic-month branch November 10, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants