-
Notifications
You must be signed in to change notification settings - Fork 4.2k
This fixes LMS-2387 by removing a resize call that prevented scrolling. #2932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this line do? If there is more than one matlab problem on a page, will those pose issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets the codemirror object. Previously, cm was available as a global variable.
Yeah, if there are more than one on the page, it'll be a problem. hmm...
|
The syntax highlighting is nice! Should also get a review by @auraz . |
|
@davestgermain resizing the textarea doesn't work |
|
It didn't work before, did it? Is it supposed to be resizable? |
|
I can't remember. But in that case, add resize: none; to the css |
|
@polesye please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this setup to the capa/display.coffee, like it was done for javascriptinput.
|
Good to merge when comments will be addressed. 👍 |
It also enables syntax highlighting for matlab input fields, which wasn't previously enabled.
|
@polesye I moved the CodeMirror setup to display.coffee, and did the same for the codeinput.html (python) code editor, because the function is identical there. |
This fixes LMS-2387 by removing a resize call that prevented scrolling.
It also enables syntax highlighting for matlab input fields, which
wasn't previously enabled.
@adampalay