Skip to content

Conversation

@davestgermain
Copy link
Contributor

It also enables syntax highlighting for matlab input fields, which
wasn't previously enabled.

@adampalay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this line do? If there is more than one matlab problem on a page, will those pose issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets the codemirror object. Previously, cm was available as a global variable.

Yeah, if there are more than one on the page, it'll be a problem. hmm...

@adampalay
Copy link
Contributor

The syntax highlighting is nice! Should also get a review by @auraz .

@adampalay
Copy link
Contributor

@davestgermain resizing the textarea doesn't work

@davestgermain
Copy link
Contributor Author

It didn't work before, did it? Is it supposed to be resizable?

@adampalay
Copy link
Contributor

I can't remember. But in that case, add resize: none; to the css

@auraz
Copy link
Contributor

auraz commented Mar 14, 2014

@polesye please review

PYushchenko added a commit to smartdec/edx-platform that referenced this pull request Mar 17, 2014
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this setup to the capa/display.coffee, like it was done for javascriptinput.

@polesye
Copy link
Contributor

polesye commented Mar 17, 2014

Good to merge when comments will be addressed. 👍

It also enables syntax highlighting for matlab input fields, which
wasn't previously enabled.
@davestgermain
Copy link
Contributor Author

@polesye I moved the CodeMirror setup to display.coffee, and did the same for the codeinput.html (python) code editor, because the function is identical there.

davestgermain pushed a commit that referenced this pull request Mar 17, 2014
This fixes LMS-2387 by removing a resize call that prevented scrolling.
@davestgermain davestgermain merged commit 372d084 into master Mar 17, 2014
@davestgermain davestgermain deleted the dcs/fix-matlab-input branch March 17, 2014 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants