Removed circuit editor setup code that had always been in codemirror-compressed.js

[davestgermain]

Previously, every page that included codemirror-compressed.js (such as every courseware page) was running code to create a modal dialog for the circuit editor. I've moved those functions to schematicinput.html where they belong.

I tried the editor, and it works (including the modal dialog), but I don't know how to verify it completely because I don't know how to edit circuits...

@cahrens @sarina

[sarina]

@Lylafischer would be a good person to ask for help with the circuit editor.
On Mar 17, 2014 12:26 PM, "Dave St.Germain" notifications@github.com
wrote:

Previously, every page that included codemirror-compressed.js (such as
every courseware page) was running code to create a modal dialog for the
circuit editor. I've moved those functions to schematicinput.html where
they belong.

I tried the editor, and it works (including the modal dialog), but I don't
know how to verify it completely because I don't know how to edit
circuits...

@cahrens https://github.com/cahrens @sarina https://github.com/sarina

You can merge this Pull Request by running

git pull https://github.com/edx/edx-platform dcs/remove-junk-from-codemirror

Or view, comment on, or merge it at:

https://github.com/edx/edx-platform/pull/2959
Commit Summary

• Removed circuit editor setup code that had always been in

File Changes

• M common/lib/capa/capa/inputtypes.pyhttps://github.com/edx/edx-platform/pull/2959/files#diff-0(2)
• M common/lib/capa/capa/templates/schematicinput.htmlhttps://github.com/edx/edx-platform/pull/2959/files#diff-1(73)
• M common/lib/capa/capa/tests/test_inputtypes.pyhttps://github.com/edx/edx-platform/pull/2959/files#diff-2(10)
• M common/static/js/vendor/CodeMirror/addons/edx_markdown.jshttps://github.com/edx/edx-platform/pull/2959/files#diff-3(64)
• R common/static/js/vendor/CodeMirror/octave.jshttps://github.com/edx/edx-platform/pull/2959/files#diff-4(0)
• M common/static/js/vendor/codemirror-compressed.jshttps://github.com/edx/edx-platform/pull/2959/files#diff-5(4)

Patch Links:

• https://github.com/edx/edx-platform/pull/2959.patch
• https://github.com/edx/edx-platform/pull/2959.diff

Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/2959
.

[davestgermain]

@Lyla-Fischer Can you verify the circuit editor still works with this PR?

[sarina]

@davestgermain @Lyla-Fischer Unfortunately I've never really used the circuit editor so I hesitate to verify these changes. Lyla should be able to at least let us know who's responsible for the editor (my assumption is Blades team) and suggest reviewers.

[Lyla-Fischer]

Dave and I had an offline conversation to manually test the student-facing functionality. we found one thing, but he reported offline that it was now fixed. In that case 👍