Fixed HTML tab in bulk email feature on firefox. #2967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
The real solution to this is to implement the editor correctly - https://edx-wiki.atlassian.net/browse/LMS-1171 |
Contributor
|
@sarina For someone not familiar with the editor code it will take quite a bit of time to do the refactoring. Don't know when we (or someone else) will get around to it. So lets merge this fix in for now. @waheedahmed Have you tested this in IE too? |
Contributor
|
@symbolist yes I know I was just pointing it out so that everyone is aware of the ticket in case they hadn't seen it. |
Contributor
Author
|
@symbolist yes I tested it on IE and its working. |
Contributor
|
@sarina ah okay, thanks! |
Contributor
|
👍 |
waheedahmed
added a commit
that referenced
this pull request
Mar 20, 2014
…-email-feature Fixed HTML tab in bulk email feature on firefox.
waheedahmed
deleted the
waheed/lms2275-fix-html-tab-in-bulk-email-feature
branch
|
#2657 gets rid of the tabbed HTML editor and uses a plugin instead (click last toolbar button, "Source code"). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LMS-2275
Clicking the HTML tab in Firefox isn't working properly for bulk email feature.