feat: Added token grant_type in JWT payload #30519
Conversation
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Thanks. Happy to discuss any questions if any of this is not clear.
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Not quite done with the review, but submitting so you can see comments.
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0014-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0014-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-add-grant-type-in-jwt-payload.rst
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/oauth_dispatch/docs/decisions/0013-mobile-migration-to-jwt.rst
Outdated
Show resolved
Hide resolved
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
@jawad-khan: This is ready from my end. Please review the ADR changes, and squash and merge if you are content. If not, I can review your questions or updates. Thanks.
There was a problem hiding this comment.
@jawad-khan: [inform] I added a custom attribute in case we want to review this data in New Relic.
There was a problem hiding this comment.
@jawad-khan: [inform] I changed the grant type for this error condition so we can more easily tell the difference between this issue, and an empty string in the db.
jawad-khan
force-pushed
the
LEARNER-8886
branch
4 times, most recently
from
c867dca to
42846b3
Compare
|
[inform] I tried rebasing, but still getting test failures. I am trying to re-run to see what happens. |
To exchange jwt with session cookies we need to determine JWT grant type in AccessTokenExchangeView. JWT only having password grant type will be allowed to exchange session. Added ADR for mobile migration to JWT authentication. LEARNER-8886
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
To exchange jwt with session cookies we need to determine JWT grant type in AccessTokenExchangeView.
JWT only having password grant type will be allowed to exchange session.
Supporting information
JIRA Issue: https://2u-internal.atlassian.net/browse/LEARNER-8886