-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Clarify a potentially confusing deprecation message [MNG-3057] #30535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify a potentially confusing deprecation message [MNG-3057] #30535
Conversation
|
Thanks for the pull request, @bradenmacdonald! I've created OSPR-6753 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
393621a to
f9c9ef1
Compare
|
@bradenmacdonald Thank you for your contribution. Is this ready for our review? |
|
@natabene Yes, thanks. I think @pomegranited would be a good reviewer. |
|
@pomegranited Would you like to review? |
|
Hi @natabene , yep, I can review! I've scheduled this for next week. |
pomegranited
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this issue @bradenmacdonald ! We converted the XBlocks in edx-platform to use the mako service's render_template method instead, but there's surely XBlocks outside the platform which still use it. So this is worth updating :)
👍
-
I tested thisN/A -- string change only - I read through the code
-
I checked for accessibility issuesN/A - Updates documentation
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
I just noticed that a certain deprecation warning hasn't been updated to mention the mako service which was introduced in #29354 , so this updates the text. I'm not sure if/when anyone is going to see this though if all the existing blocks have been converted to the new service already.
Supporting information
Testing instructions
Not really necessary.
Deadline
None
Other information
Suggested reviewer: @pomegranited