Revert to older version of TinyMCE. #3067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had trouble with Cloudfront/hashed files and need more time to investigate. This reverts commit e8f53ac9dc6d8a1d9928787635c7c5f7e409a9ec.
Contributor
|
👍 I skimmed the code and everything I was expecting to see reverted is back. I also tested the branch and the sad old UI seems to be working fine. |
Contributor
|
LGTM 🚀 |
Contributor
|
😢 👍 |
cahrens
pushed a commit
that referenced
this pull request
Mar 26, 2014
Revert to older version of TinyMCE.
Contributor
|
:'( @cahrens any conversation in edx-code to know more about your issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had issues related to Cloudfront and file hashing. More time is needed for investigation.
@rocha Here is the revert of the TinyMCE version.
@andy-armstrong Do you want to code review? It's not an easy thing to review, though perhaps you could check out the branch and do some quick manual testing with the HTML component (not that I haven't already done that...).
@frrrances Also tagging you as an interested party.
This PR reverts #2657.