Merged
Conversation
mumarkhan999
force-pushed
the
umar/add-import-linter-check
branch
from
f98cdd4 to
0a00c18
Compare
mumarkhan999
force-pushed
the
umar/add-import-linter-check
branch
5 times, most recently
from
6635490 to
db0ee54
Compare
iamsobanjaved
approved these changes
Oct 18, 2022
mumarkhan999
force-pushed
the
umar/add-import-linter-check
branch
from
114983a to
6834cd8
Compare
jmbowman
approved these changes
Nov 29, 2022
Contributor
jmbowman
left a comment
jmbowman
left a comment
There was a problem hiding this comment.
Argh, sorry about the overdue review on this; looks like a great start!
Once it's rebased and merged, I'll poke a few people who are likely to be interested and figure out where we want to go next with this.
mumarkhan999
force-pushed
the
umar/add-import-linter-check
branch
from
79fa89b to
70e9af7
Compare
mumarkhan999
force-pushed
the
umar/add-import-linter-check
branch
from
70e9af7 to
16b387b
Compare
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket Link: https://openedx.atlassian.net/browse/BOM-2576
Description:
In order to empower refactoring, restructuring, and extraction of edx-platform code, we would like to be able to analyze and make assertions about what code depends on what. One way to do this is by computing the digraph of Python import statements in our codebase, and failing PR builds if unwanted imports exist in the graph. This is exactly what the tool import-linter will allow us to do.
Note:
For now, we're ignoring the existing imports which are breaking the check of
independence.Screenshots