Skip to content

Conversation

@collinpreston
Copy link
Contributor

Description

This PR adds a checkbox for expiration_datetime_is_explicit to the Django Admin's CourseMode edit page. This allows Admin users to explicitly define an Upgrade Deadline date along with setting expiration_datetime_is_explicit to True in order to ensure that the Upgrade Deadline persists even if the course is published again.

Before
Screen Shot 2022-11-02 at 13 34 42

After
Screen Shot 2022-11-02 at 13 34 08

Supporting information

This PR was the result of this initial investigation: https://discuss.openedx.org/t/course-mode-upgrade-deadline/8498.

Testing instructions

I tested this using https://github.com/openedx/devstack which starts you out with some default courses already created.

  1. Open Studio and navigate to your existing course. Ensure that the course has an end date.
  2. Using an existing course, go to /admin/course_modes/coursemode and click the ID of the associated record in order to navigate to the course mode edit page.
  3. Edit the upgrade deadline date to be a date which is more than 10 days prior to the course end date from step 1.
  4. Ensure that the checkbox for "Upgrade Deadline Explicitly Defined" is left unchecked/False. Save the form.
  5. Go back to Studio and update the start time (I updated the time by a single minute). Save your changes.
  6. Refresh the /admin/course_modes/coursemode page and you should now see that the upgrade deadline date for your course is 10 days prior to the course end date.
  7. Repeat step 3 but this time checking/True the "Upgrade Deadline Explicitly Defined" checkbox.
  8. Repeat step 5.
  9. Refresh the /admin/course_modes/coursemode page and should now see that the upgrade deadline date is the value from step 7.

Deadline

None.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 2, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 2, 2022

Thanks for the pull request, @collinpreston! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@collinpreston collinpreston marked this pull request as ready for review November 2, 2022 19:55
@collinpreston collinpreston changed the title Course_mode admin explicitly defined upgrade deadline Course mode admin explicitly defined upgrade deadline Nov 2, 2022
@collinpreston collinpreston changed the title Course mode admin explicitly defined upgrade deadline Course mode admin explicitly defining upgrade deadline Nov 3, 2022
@collinpreston collinpreston changed the title Course mode admin explicitly defining upgrade deadline Course mode - admin explicitly defining upgrade deadline Nov 4, 2022
@collinpreston
Copy link
Contributor Author

@openedx/cla-problems the status of my Contributor Agreement check does not seem to be updating.

@feanil feanil changed the title Course mode - admin explicitly defining upgrade deadline Course mode - admin explicitly defining upgrade deadline. Nov 4, 2022
@feanil
Copy link
Contributor

feanil commented Nov 4, 2022

@collinpreston I don't see you in list of contributors, can you confirm that MIT has submitted your information to us?

@collinpreston collinpreston changed the title Course mode - admin explicitly defining upgrade deadline. Course mode admin explicitly defining upgrade deadline. Nov 7, 2022
@pdpinch
Copy link
Contributor

pdpinch commented Nov 7, 2022

@feanil I sent an email to Eden last week updating Open Learning's list of contributors. Is there something else I should do?

collinpreston and others added 3 commits November 7, 2022 11:00
@collinpreston collinpreston changed the title Course mode admin explicitly defining upgrade deadline. feat: Course mode admin explicitly defining upgrade deadline. Nov 8, 2022
@collinpreston
Copy link
Contributor Author

@feanil should I expect the Github checks to run automatically now that the CLA check passes?

@feanil
Copy link
Contributor

feanil commented Nov 8, 2022

@collinpreston no, someone will still need to review and approve those since you're a first time contributor. I'll go ahead and do that for you now. Once you're a regular contributor, you will not have to deal with that.

@collinpreston
Copy link
Contributor Author

The Javascript test is rendered without opened extra videos bar seems to be failing but does not appear related to this PR. It also appeared to fail in this PR: #28571.

@openedx-webhooks
Copy link

@collinpreston Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@jmakowski1123 jmakowski1123 added product review PR requires product review before merging and removed product review PR requires product review before merging labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants