-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: Course mode admin explicitly defining upgrade deadline. #31246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the fields for modifying expiration_datetime_is_explicit
|
Thanks for the pull request, @collinpreston! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@openedx/cla-problems the status of my Contributor Agreement check does not seem to be updating. |
|
@collinpreston I don't see you in list of contributors, can you confirm that MIT has submitted your information to us? |
|
@feanil I sent an email to Eden last week updating Open Learning's list of contributors. Is there something else I should do? |
migration to add description for upgrade deadline explicitly set.
|
@feanil should I expect the Github checks to run automatically now that the CLA check passes? |
|
@collinpreston no, someone will still need to review and approve those since you're a first time contributor. I'll go ahead and do that for you now. Once you're a regular contributor, you will not have to deal with that. |
|
The Javascript test |
|
@collinpreston Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a checkbox for
expiration_datetime_is_explicitto the Django Admin's CourseMode edit page. This allows Admin users to explicitly define an Upgrade Deadline date along with settingexpiration_datetime_is_explicitto True in order to ensure that the Upgrade Deadline persists even if the course is published again.Before

After

Supporting information
This PR was the result of this initial investigation: https://discuss.openedx.org/t/course-mode-upgrade-deadline/8498.
Testing instructions
I tested this using https://github.com/openedx/devstack which starts you out with some default courses already created.
/admin/course_modes/coursemodeand click the ID of the associated record in order to navigate to the course mode edit page./admin/course_modes/coursemodepage and you should now see that the upgrade deadline date for your course is 10 days prior to the course end date./admin/course_modes/coursemodepage and should now see that the upgrade deadline date is the value from step 7.Deadline
None.