Skip to content

Conversation

@0x29a
Copy link
Contributor

@0x29a 0x29a commented Jan 3, 2023

Description

Removes unused import and fixes test_is_marketable_set_to_false_for_user_created_via_management_command test, which is failing due to the mismatching yearOfBirth:

FAILED common/djangoapps/student/tests/test_models.py::TestUserPostSaveCallback::test_is_marketable_set_to_false_for_user_created_via_management_command - AssertionError: assert (1, {'address...': None, ...}) == (1, {'address...': None, ...})
  At index 1 diff: {'email': 'some.user@example.com', 'username': 'some_user', 'name': 'Student Person', 'age': -1, 'yearOfBirth': 2023, 'education': None, 'address': None, 'gender': 'Male', 'country': '', 'is_marketable': False} != {'email': 'some.user@example.com', 'username': 'some_user', 'name': 'Student Person', 'age': -1, 'yearOfBirth': 2022, 'education': None, 'address': None, 'gender': 'Male', 'country': '', 'is_marketable': False}
  Full diff:
    (
     1,
     {'address': None,
      'age': -1,
      'country': '',
      'education': None,
      'email': 'some.user@example.com',
      'gender': 'Male',
      'is_marketable': False,
      'name': 'Student Person',
      'username': 'some_user',
  -   'yearOfBirth': 2022},
  ?                     ^
  +   'yearOfBirth': 2023},
  ?                     ^
    )
===== 1 failed, 997 passed, 825 skipped, 145 warnings in 101.19s (0:01:41) =====

Testing instructions

All pipeline checks should pass.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 3, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @0x29a! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy New Year 😂 !

@dianakhuang dianakhuang merged commit 21424bb into openedx:master Jan 3, 2023
@openedx-webhooks
Copy link

@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@0x29a 0x29a deleted the 0x29a/fix-hardcoded-date-of-birth branch January 3, 2023 16:10
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@asadali145
Copy link
Contributor

This needs to be back-ported to Olive and other maintained releases if any.

0x29a added a commit to open-craft/openedx-platform that referenced this pull request Jan 5, 2023
@0x29a
Copy link
Contributor Author

0x29a commented Jan 5, 2023

@asadali145, here it is.

pdpinch pushed a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants