-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[FC-0009] Show a preview of what will be pasted with new Paste Component Button #32132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @bradenmacdonald! As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
cc1fb98 to
7bd7c52
Compare
7bd7c52 to
f7c3595
Compare
|
@Agrendalath @ormsbee This is ready for review. |
Agrendalath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the preview behaves as described (even when the parent of the source XBlock is removed)
- I read through the code
- I checked for accessibility issues
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
|
Thanks for the review @Agrendalath. I addressed your comments. |
f24c413 to
bfa81d2
Compare
|
@ormsbee, would you like to review this before we merge? |
|
@Agrendalath: No, it's fine. Please go ahead. |
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
This continues the work from #31969 and implements ticket openedx/modular-learning#13
Affects: course authors [for now, only those who will be participating in the beta test]
Screenshot of the "Paste Component" button with the new preview:
Supporting information
See tickets linked above.
Testing instructions
contentstore.enable_copy_paste_featurefor Everyone, if you haven't already.Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
TODOs
Other information
Private ref: MNG-3637