Skip to content

Conversation

@bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented Apr 25, 2023

Description

This continues the work from #31969 and implements ticket openedx/modular-learning#13

Affects: course authors [for now, only those who will be participating in the beta test]

Screenshot of the "Paste Component" button with the new preview:

Screenshot 2023-04-25 at 3 42 06 PM

Supporting information

See tickets linked above.

Testing instructions

  1. Go to (studio)/admin/waffle/flag/ and enable contentstore.enable_copy_paste_feature for Everyone, if you haven't already.
  2. Use the new Actions menu to select Copy. You should see an animation and the "Paste Component" button should appear.
  3. Hover over the "What's in my clipboard" as shown in the screenshot. Click on it to be taken to the original source location in Studio.
  4. Delete the original source XBlock and refresh the page.
  5. The "What's in my clipboard?" should still work, but will no longer be clickable.
  6. Note that the "What's in my clipboard" appears on hover and will also stay on click. It's also keyboard accessible as simply tabbing onto "What's in my clipboard" will make it appear and you can then tab onto the popup from there.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

TODOs

  • Hide the popup until hover/click
  • Merge the PR that this one depends on and then rebase it, to make the diff smaller.

Other information

Private ref: MNG-3637

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 25, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald!

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@bradenmacdonald
Copy link
Contributor Author

@Agrendalath @ormsbee This is ready for review.

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the preview behaves as described (even when the parent of the source XBlock is removed)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@bradenmacdonald
Copy link
Contributor Author

Thanks for the review @Agrendalath. I addressed your comments.

@Agrendalath
Copy link
Member

@ormsbee, would you like to review this before we merge?

@ormsbee
Copy link
Contributor

ormsbee commented May 5, 2023

@Agrendalath: No, it's fine. Please go ahead.

@Agrendalath Agrendalath merged commit 4b72194 into openedx:master May 5, 2023
@Agrendalath Agrendalath deleted the paste-preview branch May 5, 2023 15:35
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core committer open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants