Revert "Revert "feat: remove field-data binding from the runtime [FC-0026]" (openedx#32740)" #32737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @Agrendalath! As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
ormsbee
approved these changes
Jul 13, 2023
Agrendalath
force-pushed
the
agrendalath/revert-revert_fc-0026-cache_runtime_services_and_wrappers
branch
2 times, most recently
from
d7fd25b to
d113890
Compare
…0026]" (openedx#32740)" This reverts commit fa06be1.
Agrendalath
force-pushed
the
agrendalath/revert-revert_fc-0026-cache_runtime_services_and_wrappers
branch
from
d113890 to
b574fc0
Compare
Agrendalath
changed the title
Member
Author
|
@ormsbee, I updated this PR to re-revert only the |
ormsbee
approved these changes
Jul 18, 2023
Agrendalath
deleted the
agrendalath/revert-revert_fc-0026-cache_runtime_services_and_wrappers
branch
|
@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c6bd98e (from #32730), which reverted #32420. It also reverts cd31c18 and d5cd535 (from #32740), which reverted #32357.Edit: apparently, #32740 was squashed, so we cannot cleanly revert it anymore. We will need to revert fa06be1 instead.
That first revert didn't fix the issue, so we can revert this revert. If #32740 won't fix this issue, too, we can do a clean rebase of this PR through the GitHub UI (to drop the first two commits, which are in the mentioned PR).This reverts #32740. After reproducing the issue locally, it turned out that the first revert (#32730) fixed the underlying issue.