fix: include new assets.txt file in make upgrade #32860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
reviewed
Jul 27, 2023
| edx-braze-client==0.1.7 | ||
| # via -r requirements/edx/bundled.in | ||
| edx-bulk-grades==1.0.1 | ||
| edx-bulk-grades==1.0.2 |
awais786
reviewed
Jul 27, 2023
| edx-ccx-keys==1.2.1 | ||
| # via -r requirements/edx/kernel.in | ||
| edx-celeryutils==1.2.2 | ||
| edx-celeryutils==1.2.3 |
awais786
reviewed
Jul 27, 2023
| edx-codejail==3.3.3 | ||
| # via -r requirements/edx/kernel.in | ||
| edx-completion==4.2.1 | ||
| edx-completion==4.3.0 |
awais786
reviewed
Jul 27, 2023
requirements/edx/base.txt
Outdated
| edx-completion==4.3.0 | ||
| # via -r requirements/edx/kernel.in | ||
| edx-django-release-util==1.2.0 | ||
| edx-django-release-util==1.3.0 |
Contributor
There was a problem hiding this comment.
It has migration due to django40
awais786
approved these changes
Jul 27, 2023
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Member
|
My mistake, thanks for the fix @UsamaSadiq ! |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
npm run build(experimental) #32823 introduced two new Python requirements filesassets.inandassets.txt. Since these files were not included in themake upgradetarget, it broke both theUpgrade RequirementsandUpgrade one dependencyworkflows due to requirements conflicts when upgrading packages.make upgradetarget will fix both of the failing jobs as well asmake upgradetarget running locally.Testing
Requirements Upgradeworkflow build against this branch.