-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix backports-zoneinfo requirement not to affect python >= 3.9 #32873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @VanDavv! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
|
Hi @VanDavv, we need to have a valid Contributor License Agreement (CLA) in place for all contributions. See the welcome message above for the details about how to enroll. The process is different depending upon whether you are making this contribution as an individual or on behalf of your employer. I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard? |
Hi @VanDavv! Just following up on this? Please let us know if you have any questions. Thanks! |
|
Hi @VanDavv! I am going to close this pull request for now, though we can reopen should you choose to pursue in the future. Thanks! |
|
@VanDavv Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
|
@VanDavv Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Found while working on #32872. Per this SO answer, the
backports-zoneinfopackage should not be used for Python versions 3.9 or higher.In some of the openedx repositories, we can already see this condition in place, e.g. here:
But it was not included in the
edx-platformrepository itselfUseful information to include:
These changes will enable Developers using Python 3.9 or higher to install the edx-platform requirements without running into installation issues
Supporting information
StackOverflow issue link - https://stackoverflow.com/questions/71712258/error-could-not-build-wheels-for-backports-zoneinfo-which-is-required-to-insta
Testing instructions
make requirementsinside theedx-platformrepositoryWithout this PR, the installation will fail with the following issue
With this PR, the
backports-zoneinfopackage won't be installed for Python 3.9 or higher and the issue won't occurDeadline
None