Skip to content

Conversation

@VanDavv
Copy link

@VanDavv VanDavv commented Jul 28, 2023

Description

Found while working on #32872. Per this SO answer, the backports-zoneinfo package should not be used for Python versions 3.9 or higher.
In some of the openedx repositories, we can already see this condition in place, e.g. here:

But it was not included in the edx-platform repository itself

Useful information to include:

These changes will enable Developers using Python 3.9 or higher to install the edx-platform requirements without running into installation issues

Supporting information

StackOverflow issue link - https://stackoverflow.com/questions/71712258/error-could-not-build-wheels-for-backports-zoneinfo-which-is-required-to-insta

Testing instructions

  • Install Python 3.9 or higher (tested on 3.11)
  • Run make requirements inside the edx-platform repository

Without this PR, the installation will fail with the following issue

lib/zoneinfo_module.c:600:19: error: ‘_PyLong_One’ undeclared (first use in this function); did you mean ‘_PyLong_New’?

With this PR, the backports-zoneinfo package won't be installed for Python 3.9 or higher and the issue won't occur

Deadline

None

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 3, 2023

Thanks for the pull request, @VanDavv! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 3, 2023
@mphilbrick211
Copy link

Hi @VanDavv! Please let me know if you have any questions regarding filling out the CLA form. Thanks!

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 7, 2023
@e0d
Copy link
Contributor

e0d commented Aug 16, 2023

Hi @VanDavv, we need to have a valid Contributor License Agreement (CLA) in place for all contributions. See the welcome message above for the details about how to enroll. The process is different depending upon whether you are making this contribution as an individual or on behalf of your employer.

I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Aug 16, 2023
@mphilbrick211 mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 12, 2023
@mphilbrick211
Copy link

Hi @VanDavv, we need to have a valid Contributor License Agreement (CLA) in place for all contributions. See the welcome message above for the details about how to enroll. The process is different depending upon whether you are making this contribution as an individual or on behalf of your employer.

I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

Hi @VanDavv! Just following up on this? Please let us know if you have any questions. Thanks!

@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Oct 25, 2023
@mphilbrick211
Copy link

Hi @VanDavv! I am going to close this pull request for now, though we can reopen should you choose to pursue in the future. Thanks!

@openedx-webhooks
Copy link

@VanDavv Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@VanDavv Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants