fix: fix middleware get_response parameter deprecation warning #33067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
commented
Aug 21, 2023
Member
Author
UsamaSadiq
left a comment
UsamaSadiq
left a comment
There was a problem hiding this comment.
Super() doesn't take any keyword arguments.
UsamaSadiq
commented
Aug 21, 2023
Member
Author
UsamaSadiq
left a comment
UsamaSadiq
left a comment
There was a problem hiding this comment.
Super() can't have function as argument.
UsamaSadiq
force-pushed
the
fix-middleware-get-response-deprecation-warning
branch
from
ea0a900 to
c602edd
Compare
irtazaakram
approved these changes
Aug 22, 2023
UsamaSadiq
force-pushed
the
fix-middleware-get-response-deprecation-warning
branch
from
7bf9661 to
e6f7a11
Compare
awais786
approved these changes
Aug 22, 2023
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
mehedikhan72
pushed a commit
to mehedikhan72/edx-platform
that referenced
this pull request
Aug 24, 2023
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description