-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: [FC-0031] Add DefaultPagination in UserCourseEnrollmentsList #33294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0031] Add DefaultPagination in UserCourseEnrollmentsList #33294
Conversation
|
Thanks for the pull request, @oksana-slu! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
0f8e29e to
6ed7a38
Compare
a62bad8 to
4db3131
Compare
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments inline. Generally, I wonder if overloading all the API versions into one class still makes sense or if we should make a new API class that calls the same underlying business logic functions. This way the DRF machinery is better separated from the shared business logic. It will duplicate the comments a bit but given that there are changes between API versions and we're not updating the view docstring, maybe it would make that sort of thing easier to catch.
|
@GlugovGrGlib I think this is good to go but we should update the docs/comment as suggested above first. |
|
Let me know when that's done and I can coordinate merging it. |
This will be updated today, thanks! |
403b9e3 to
95fcb12
Compare
|
@oksana-slu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
The pagination is necessary for UserCourseEnrollmentsList to optimize course loading in the mobile app.
The pagination for this endpoint was introduced along with a new version (v3) of the mobile API.
Supporting information
This contribution is done as a part of the project FC-0031
Testing instructions
api/mobileendpoints are now available with v3 api version.GET
/api/mobile/v3/users/<user_name>/course_enrollments/, and see the Default Pagination fields, as count, num_pages, current_page, results in the response.