Skip to content

[BACKPORT] fix: replace py2neo with forked package (#33453) #33459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timmc-edx merged 1 commit into from
Oct 10, 2023
Merged

[BACKPORT] fix: replace py2neo with forked package (#33453) #33459

timmc-edx merged 1 commit into from
Oct 10, 2023

Conversation

@cmltaWt0
Copy link
Contributor

@cmltaWt0 cmltaWt0 commented Oct 10, 2023

Backport of #33453

Description

  • py2neo official PyPI and GitHub packages have been removed.
  • using fork as a quick fix

Testing instructions

  • Checkout source branch
  • do docker build -t platform-test .

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 10, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 10, 2023

Thanks for the pull request, @cmltaWt0! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 requested a review from a team October 10, 2023 17:18
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 10, 2023
@mphilbrick211
Copy link

mphilbrick211 commented Oct 10, 2023

Hi @openedx/arch-bom! Would someone be able to please review/merge for us? The master has been merged.

@timmc-edx
Copy link
Contributor

timmc-edx commented Oct 10, 2023

It looks like this backport is incomplete -- there should be a corresponding change to a .in file. The structure of requirements files may have changed since Palm was branched.

@mphilbrick211
Copy link

mphilbrick211 commented Oct 10, 2023

It looks like this backport is incomplete -- there should be a corresponding change to a .in file. The structure of requirements files may have changed since Palm was branched.

Hi @cmltaWt0! Please see the comment above.

@mphilbrick211 mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 10, 2023
@UsamaSadiq @cmltaWt0
fix: replace py2neo with forked package (openedx#33453)
4793b8e 
* fix: replace py2neo with overhangio py2neo fork
@cmltaWt0 cmltaWt0 force-pushed the max/py2neo-backport branch from d51bfbc to 4793b8e Compare October 10, 2023 20:10
@cmltaWt0
Copy link
Contributor Author

cmltaWt0 commented Oct 10, 2023

@mphilbrick211 @timmc-edx

You are totally right - missed it. Thanks!
PR has been updated.

@timmc-edx timmc-edx merged commit 176d0d8 into openedx:open-release/palm.master Oct 10, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 10, 2023

@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

ahmed-arb pushed a commit to wikimedia/edx-platform that referenced this pull request Oct 17, 2023
@cmltaWt0 @UsamaSadiq @ahmed-arb
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
2d8735b 
Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
ahmed-arb added a commit to wikimedia/edx-platform that referenced this pull request Oct 17, 2023
@ahmed-arb @cmltaWt0 @UsamaSadiq
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)…
2779e3d 
… (#365)

Co-authored-by: Max Sokolski <cmltawt0@gmail.com>
Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
becdavid added a commit to CUCWD/edx-platform that referenced this pull request Dec 11, 2023
@becdavid @UsamaSadiq
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
958b99b 
Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
shURenZHOUluxun pushed a commit to EduTrigger/edx-platform that referenced this pull request Jan 3, 2024
@cmltaWt0 @UsamaSadiq @shURenZHOUluxun
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
46da449 
Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
ztraboo added a commit to CUCWD/edx-platform that referenced this pull request Apr 12, 2024
@ztraboo @UsamaSadiq
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
ccfadf5 
Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
a-kryachko pushed a commit to raccoongang/edx-platform that referenced this pull request Jun 14, 2024
@cmltaWt0 @UsamaSadiq @a-kryachko
fix: replace py2neo with forked package (openedx#33453) (openedx#33459)
22ce273 
Co-authored-by: Usama Sadiq <usama.sadiq@arbisoft.com>
@OmarIthawi OmarIthawi mentioned this pull request Jul 24, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cmltaWt0 @openedx-webhooks @mphilbrick211 @timmc-edx @UsamaSadiq