refactor: Increase size for mobile config singelton value #34288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawad-khan
approved these changes
Feb 26, 2024
feanil
requested changes
Feb 26, 2024
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
This needs a better description of why this is happening. The Jira link is not public.
feanil
approved these changes
Feb 27, 2024
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
25 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MobileConfig model is used as a singleton model (a single instance/row of this model exists at a time). The value attribute of this single instance/row is used to store JSON configs that are consumed by mobile for trivial app configs and server based toggles. We need to increase the length of this variable to store more wholesome data as needed now and in the long term future.
JIRA ticket: https://2u-internal.atlassian.net/browse/LEARNER-9862