feat!: remove SkillTaggingMixin from common XBLOCK_MIXINS #34530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a core feature, and it is not installed into core requirements, evidenced by the fact that it must be try-except imported into common.py. Instead, setting updates like this should be made in each operator's private settings file. BREAKING CHANGE: Operators who install the xblock-skilltagging package will need to add SkillTaggingMixin to XBLOCK_MIXINS_EXTRA in a private settings file, as it will no longer be done automatically in private.py.
feanil
approved these changes
Apr 17, 2024
ormsbee
approved these changes
Apr 17, 2024
kdmccormick
added
the
business-specific
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skill tagging [1] is not a core feature, and it is not installed into core requirements, evidenced by the fact that a try-except clause must be used to import it into common settings. Setting overrides like this should be made in each operator's private settings file rather than the upstream common settings file.
BREAKING CHANGE: Operators who install the xblock-skilltagging package will need to add SkillTaggingMixin to XBLOCK_MIXINS_EXTRA (or XBLOCK_MIXINS) in a private settings/YAML file, as it will no longer be done automatically in common settings. The README for xblock-skilltagging has an example [2]
[1] https://github.com/openedx/xblock-skill-tagging
[2] https://github.com/openedx/xblock-skill-tagging?tab=readme-ov-file#configuration
Other information
Essentially, this reverts #34130
Merge considerations
We'll give 2U a chance to update their private YAML file before merging.
However, this needs to merge before the Redwood cut, which is happening between May 1 and May 9. So, I plan to merge this April 29th.