test: check both dev and prod asset builds (with npm run) #34836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
approved these changes
May 21, 2024
kdmccormick
force-pushed
the
kdmccormick/paver-rm-1.5-assets-check
branch
3 times, most recently
from
d879e5b to
972501f
Compare
This switches the static asset check over from the deprecated paver commands to the new 'npm run build' command. Doing so allows us to check both the prod AND dev build, whereas before we were only checking the prod build. Please note that, as before, the "check" is only ensuring that the build returns 0. It is not checking the contents of the build output. Closes: openedx#34834
kdmccormick
force-pushed
the
kdmccormick/paver-rm-1.5-assets-check
branch
from
972501f to
aaba274
Compare
Member
Author
|
@feanil I pushed a couple small fixes. Feel free to rereview, otherwise I'll merge tomorrow AM. |
Closed
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
andrey-canon
pushed a commit
to nelc/edx-platform
that referenced
this pull request
Nov 20, 2024
This switches the static asset check over from the deprecated paver commands to the new 'npm run build' command. Doing so allows us to check both the prod AND dev build, whereas before we were only checking the prod build. Please note that, as before, the "check" is only ensuring that the build returns 0. It is not checking the contents of the build output. Closes: openedx#34834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the static asset check over from the deprecated paver commands to the new 'npm run build' command. Doing so allows us to check both the prod AND dev build, whereas before we were only checking the prod build.
Please note that, as before, the "check" is only ensuring that the build returns 0. It is not checking the contents of the build output.
Closes: #34834