-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: Added mobile api for course enrollment and other details. #35100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@GlugovGrGlib can you or someone from your team give this PR a look? |
| @@ -1,3 +0,0 @@ | |||
| # We want to ignore files in this directory which we do in the | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment no longer accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed from PR.
| @ddt.data( | ||
| ({'is_downloadable': True, 'download_url': 'https://test_certificate_url'}, | ||
| {'url': 'https://test_certificate_url'}), | ||
| ({'is_downloadable': False}, {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you deleted a test here that perform the negative test (does your code do the right thing if is_downloadable is False) and I don't see that you replaced it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added separate test case for this.
9ebf422 to
6a5f894
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
…edx#35100) * feat: Added mobile api for course enrollment and other details.
…edx#35100) * feat: Added mobile api for course enrollment and other details.
Description
Added mobile api for course enrollment and other details. This api provide a separate endpoint for all course enrollment details.
Useful information to include:
Supporting information
Jira Ticket: https://2u-internal.atlassian.net/browse/LEARNER-10031
Sample response data that this api should return
Testing instructions
Call api
/api/mobile/{api_version}/course_info/{course_id}}/enrollment_detailsand compare data with expected data given above.
Deadline
"ASAP".