Skip to content

Conversation

@kdmccormick
Copy link
Member

Description

Somewhere in the series of refactorings that this app has undergone, it seems that we removed TestCase from the inheritance tree of the tests in openedx/core/djangoapps/content_libraries/tests/test_runtime.py, effectively skipping the test cases.

This PR turns them back into tests. TODO: Fix the test failures.

Testing instructions

Check the logs of openedx-1-with-lms and openedx-2-with-cms to confirm that test_runtime is executing.

Deadline

Sooner better than later

Other information

This could have been avoided if we had:

@kdmccormick kdmccormick added the content libraries misc Libraries Overhaul tech work not captured in the stories label Sep 24, 2024
@kdmccormick
Copy link
Member Author

Things that are breaking:

  • No such function api.create_library_block_for_child
  • isinstance(i18n_service.translator, GNUTranslations)
  • anonymous user state

@kdmccormick kdmccormick force-pushed the kdmccormick/test-content-libraries-runtime branch from 20ada9f to c298ce6 Compare October 15, 2024 20:32
@bradenmacdonald
Copy link
Contributor

@kdmccormick We don't need to support api.create_library_block_for_child since we aren't going to support child blocks in libraries at all AFAIK.

@bradenmacdonald
Copy link
Contributor

@kdmccormick Do you want help with this, or are you planning to finish it up? We can definitely take it on if you'd like.

@kdmccormick
Copy link
Member Author

I had no immediate plans to work on it, so by all means feel free to take it over!

@kdmccormick
Copy link
Member Author

Closed in favor of #35783

@kdmccormick kdmccormick closed this Nov 7, 2024
@kdmccormick kdmccormick deleted the kdmccormick/test-content-libraries-runtime branch November 7, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content libraries misc Libraries Overhaul tech work not captured in the stories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants